]> www.infradead.org Git - users/hch/misc.git/commitdiff
ovl: remove redundant IOCB_DIO_CALLER_COMP clearing
authorSeong-Gwang Heo <heo@mykernel.net>
Thu, 9 Oct 2025 05:41:48 +0000 (13:41 +0800)
committerChristian Brauner <brauner@kernel.org>
Fri, 10 Oct 2025 12:02:47 +0000 (14:02 +0200)
The backing_file_write_iter() function, which is called
immediately after this code, already contains identical
logic to clear the IOCB_DIO_CALLER_COMP flag along with
the same explanatory comment. There is no need to duplicate
this operation in the overlayfs code.

Signed-off-by: Seong-Gwang Heo <heo@mykernel.net>
Fixes: a6293b3e285c ("fs: factor out backing_file_{read,write}_iter() helpers")
Acked-by: Miklos Szeredi <mszeredi@redhat.com>
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/overlayfs/file.c

index fc52c796061dc8bfe620abb6df6e7f77c0693442..7ab2c9daffd0176b7a28f26ef790e5d37919a0a1 100644 (file)
@@ -369,11 +369,6 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
        if (!ovl_should_sync(OVL_FS(inode->i_sb)))
                ifl &= ~(IOCB_DSYNC | IOCB_SYNC);
 
-       /*
-        * Overlayfs doesn't support deferred completions, don't copy
-        * this property in case it is set by the issuer.
-        */
-       ifl &= ~IOCB_DIO_CALLER_COMP;
        ret = backing_file_write_iter(realfile, iter, iocb, ifl, &ctx);
 
 out_unlock: