]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
r8152: Add RTL8152_INACCESSIBLE to r8153_aldps_en()
authorDouglas Anderson <dianders@chromium.org>
Wed, 29 Nov 2023 21:25:24 +0000 (13:25 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Dec 2023 12:22:01 +0000 (12:22 +0000)
Delay loops in r8152 should break out if RTL8152_INACCESSIBLE is set
so that they don't delay too long if the device becomes
inaccessible. Add the break to the loop in r8153_aldps_en().

Fixes: 4214cc550bf9 ("r8152: check if disabling ALDPS is finished")
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/r8152.c

index 3958eb622d4731f51e9bd3d3e2bc02fbc1d8e20e..fcdc9ba0f826b679ba5fe1f1e63fe52395670075 100644 (file)
@@ -5803,6 +5803,8 @@ static void r8153_aldps_en(struct r8152 *tp, bool enable)
                data &= ~EN_ALDPS;
                ocp_reg_write(tp, OCP_POWER_CFG, data);
                for (i = 0; i < 20; i++) {
+                       if (test_bit(RTL8152_INACCESSIBLE, &tp->flags))
+                               return;
                        usleep_range(1000, 2000);
                        if (ocp_read_word(tp, MCU_TYPE_PLA, 0xe000) & 0x0100)
                                break;