drm/etnaviv: Warn when GPU doesn't idle fast enough

If the GPU isn't idle after signalling pm_runtime_mark_last_busy() plus
waiting for the autosuspend delay there's likely something wrong with
the way we check idleness so warn about that.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index 26fe34086a602be80a91862bf0c41fde4fb123f3..169db7cc0ec60cd24ebf56bd4ca64ad092ebd3e7 100644 (file)
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1839,8 +1839,11 @@ static int etnaviv_gpu_rpm_suspend(struct device *dev)
        mask = gpu->idle_mask & ~(VIVS_HI_IDLE_STATE_FE |
                                  VIVS_HI_IDLE_STATE_MC);
        idle = gpu_read(gpu, VIVS_HI_IDLE_STATE) & mask;
-       if (idle != mask)
+       if (idle != mask) {
+               dev_warn_ratelimited(dev, "GPU not yet idle, mask: 0x%08x\n",
+                                    idle);
                return -EBUSY;
+       }
 
        return etnaviv_gpu_hw_suspend(gpu);
 }