]> www.infradead.org Git - users/hch/misc.git/commitdiff
panthor: set owner field for driver fops
authorChia-I Wu <olvaffe@gmail.com>
Fri, 18 Jul 2025 06:38:14 +0000 (23:38 -0700)
committerSteven Price <steven.price@arm.com>
Thu, 24 Jul 2025 12:42:49 +0000 (13:42 +0100)
It allows us to get rid of manual try_module_get / module_put.

Signed-off-by: Chia-I Wu <olvaffe@gmail.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250718063816.1452123-2-olvaffe@gmail.com
drivers/gpu/drm/panthor/panthor_drv.c

index 0304eb83d0b2d725154bbc84bab00f7adea96868..9256806eb6623b6a61cda084d64db73febc73c17 100644 (file)
@@ -1401,14 +1401,9 @@ panthor_open(struct drm_device *ddev, struct drm_file *file)
        struct panthor_file *pfile;
        int ret;
 
-       if (!try_module_get(THIS_MODULE))
-               return -EINVAL;
-
        pfile = kzalloc(sizeof(*pfile), GFP_KERNEL);
-       if (!pfile) {
-               ret = -ENOMEM;
-               goto err_put_mod;
-       }
+       if (!pfile)
+               return -ENOMEM;
 
        pfile->ptdev = ptdev;
        pfile->user_mmio.offset = DRM_PANTHOR_USER_MMIO_OFFSET;
@@ -1440,9 +1435,6 @@ err_destroy_vm_pool:
 
 err_free_file:
        kfree(pfile);
-
-err_put_mod:
-       module_put(THIS_MODULE);
        return ret;
 }
 
@@ -1455,7 +1447,6 @@ panthor_postclose(struct drm_device *ddev, struct drm_file *file)
        panthor_vm_pool_destroy(pfile);
 
        kfree(pfile);
-       module_put(THIS_MODULE);
 }
 
 static const struct drm_ioctl_desc panthor_drm_driver_ioctls[] = {
@@ -1556,6 +1547,7 @@ static void panthor_show_fdinfo(struct drm_printer *p, struct drm_file *file)
 }
 
 static const struct file_operations panthor_drm_driver_fops = {
+       .owner = THIS_MODULE,
        .open = drm_open,
        .release = drm_release,
        .unlocked_ioctl = drm_ioctl,