]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
accel/rocket: Check the correct DMA irq status to warn about
authorHeiko Stuebner <heiko@sntech.de>
Mon, 18 Aug 2025 18:56:58 +0000 (20:56 +0200)
committerTomeu Vizoso <tomeu@tomeuvizoso.net>
Mon, 1 Sep 2025 10:11:28 +0000 (12:11 +0200)
Right now, the code checks the DMA_READ_ERROR state 2 times, while
I guess it was supposed to warn about both read and write errors.

Change the 2nd check to look at the write-error flag.

Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Link: https://lore.kernel.org/r/20250818185658.2585696-1-heiko@sntech.de
drivers/accel/rocket/rocket_job.c

index f6fe1a6d9264b7508a3adc03248e5a704c68c4f0..acd606160dc9bdda7895a9f82d36e4be56094f4c 100644 (file)
@@ -422,7 +422,7 @@ static irqreturn_t rocket_job_irq_handler(int irq, void *data)
        u32 raw_status = rocket_pc_readl(core, INTERRUPT_RAW_STATUS);
 
        WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
-       WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_READ_ERROR);
+       WARN_ON(raw_status & PC_INTERRUPT_RAW_STATUS_DMA_WRITE_ERROR);
 
        if (!(raw_status & PC_INTERRUPT_RAW_STATUS_DPU_0 ||
              raw_status & PC_INTERRUPT_RAW_STATUS_DPU_1))