]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: rcar-vin: Do not set file->private_data
authorJacopo Mondi <jacopo.mondi@ideasonboard.com>
Sun, 10 Aug 2025 01:29:59 +0000 (04:29 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 06:33:32 +0000 (08:33 +0200)
The R-Car VIN driver sets file->private_data to the driver-specific
structure, but the following call to v4l2_fh_open() overwrites it
with a pointer to the just allocated v4l2_fh.

Remove the mis-leading assignment in the driver.

Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/rcar-vin/rcar-v4l2.c

index 62eddf3a35fc91434cb2e584a01819380a7a6dd8..079dbaf016c25139e2ac82be63d8fce0d11fd208 100644 (file)
@@ -588,8 +588,6 @@ static int rvin_open(struct file *file)
        if (ret)
                goto err_pm;
 
-       file->private_data = vin;
-
        ret = v4l2_fh_open(file);
        if (ret)
                goto err_unlock;