]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: spi-cadence: Enable spi refclk in slave mode
authorAmit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Mon, 17 Jun 2024 15:38:37 +0000 (21:08 +0530)
committerMark Brown <broonie@kernel.org>
Wed, 19 Jun 2024 12:54:17 +0000 (13:54 +0100)
When spi-cadence is configured as a slave, it requires the SPI refclk to
detect the synchronization start condition while communicating with the
master. However, the spi-cadence driver never enables the SPI refclk in
slave mode, causing the refclk to remain disabled if the
"clk_ignore_unused" kernel parameter is not passed through bootargs.
As a result, the slave cannot detect data sent by the master, leading to
communication failure. Update driver to enable the SPI refclk in both
master and slave configurations.

Fixes: b1b90514eaa3 ("spi: spi-cadence: Add support for Slave mode")
Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Link: https://msgid.link/r/20240617153837.29861-1-amit.kumar-mahapatra@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence.c

index 4eacf3f6e031e8def140f34201dc0cc7285bc220..e07e081de5ea418e9fcc7d6aae5a3eeedda94d86 100644 (file)
@@ -601,14 +601,14 @@ static int cdns_spi_probe(struct platform_device *pdev)
        reset_control_assert(xspi->rstc);
        reset_control_deassert(xspi->rstc);
 
-       if (!spi_controller_is_target(ctlr)) {
-               xspi->ref_clk = devm_clk_get_enabled(&pdev->dev, "ref_clk");
-               if (IS_ERR(xspi->ref_clk)) {
-                       dev_err(&pdev->dev, "ref_clk clock not found.\n");
-                       ret = PTR_ERR(xspi->ref_clk);
-                       goto remove_ctlr;
-               }
+       xspi->ref_clk = devm_clk_get_enabled(&pdev->dev, "ref_clk");
+       if (IS_ERR(xspi->ref_clk)) {
+               dev_err(&pdev->dev, "ref_clk clock not found.\n");
+               ret = PTR_ERR(xspi->ref_clk);
+               goto remove_ctlr;
+       }
 
+       if (!spi_controller_is_target(ctlr)) {
                pm_runtime_use_autosuspend(&pdev->dev);
                pm_runtime_set_autosuspend_delay(&pdev->dev, SPI_AUTOSUSPEND_TIMEOUT);
                pm_runtime_get_noresume(&pdev->dev);