]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
brcmfmac: remove Comparison to bool in brcmf_p2p_send_action_frame()
authorJason Yan <yanaijie@huawei.com>
Fri, 8 May 2020 07:43:51 +0000 (15:43 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 12 May 2020 08:52:35 +0000 (11:52 +0300)
Fix the following coccicheck warning:

drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c:1785:5-8:
WARNING: Comparison to bool

Signed-off-by: Jason Yan <yanaijie@huawei.com>
Reviewed-by: Chi-hsien Lin <chi-hsien.lin@cypress.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200508074351.19193-1-yanaijie@huawei.com
drivers/net/wireless/broadcom/brcm80211/brcmfmac/p2p.c

index b0a41cf06c99ff028b6c61f970fadcdb7921ac3a..d2795dc17c464f32da17ee64df0f9cad9a6838ef 100644 (file)
@@ -1866,7 +1866,7 @@ bool brcmf_p2p_send_action_frame(struct brcmf_cfg80211_info *cfg,
                dwell_overflow = brcmf_p2p_check_dwell_overflow(requested_dwell,
                                                                dwell_jiffies);
        }
-       if (ack == false) {
+       if (!ack) {
                bphy_err(drvr, "Failed to send Action Frame(retry %d)\n",
                         tx_retry);
                clear_bit(BRCMF_P2P_STATUS_GO_NEG_PHASE, &p2p->status);