mtd: phram: only call platform_driver_unregister if phram_setup fails

The check on ret and call to platform_driver_unregister is only required
in the code path where MODULE is not defined. Fix this by moving this
code into the relevant place after the call to phram_setup.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>

diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index f756c60a4931d5d62eb1aafb719621011cb9c09a..b8bbc7ecbe953835e2bef3540f90656a55a0ceff 100644 (file)
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -415,14 +415,14 @@ static int __init init_phram(void)
                return ret;
 
 #ifndef MODULE
-       if (phram_paramline[0])
+       if (phram_paramline[0]) {
                ret = phram_setup(phram_paramline);
+               if (ret)
+                       platform_driver_unregister(&phram_driver);
+       }
        phram_init_called = 1;
 #endif
 
-       if (ret)
-               platform_driver_unregister(&phram_driver);
-
        return ret;
 }