]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: adau1977: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Thu, 28 Aug 2025 07:53:58 +0000 (15:53 +0800)
committerMark Brown <broonie@kernel.org>
Thu, 28 Aug 2025 14:07:45 +0000 (16:07 +0200)
Change the 'ret' variable from unsigned int to int to store negative error
codes or zero returned by regmap_update_bits().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Message-ID: <20250828075406.386208-3-rongqianfeng@vivo.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/adau1977.c

index ae59efb38f265f039ee1e362c4a893816c46aeb8..c193a9f22f59012578376c2a3d9b3a6206a5eb13 100644 (file)
@@ -795,7 +795,7 @@ static int adau1977_set_sysclk(struct snd_soc_component *component,
        struct adau1977 *adau1977 = snd_soc_component_get_drvdata(component);
        unsigned int mask = 0;
        unsigned int clk_src;
-       unsigned int ret;
+       int ret;
 
        if (dir != SND_SOC_CLOCK_IN)
                return -EINVAL;