ASoC: codec: sma1307: Fix memory corruption in sma1307_setting_loaded()

The sma1307->set.header_size is how many integers are in the header
(there are 8 of them) but instead of allocating space of 8 integers
we allocate 8 bytes.  This leads to memory corruption when we copy data
it on the next line:

        memcpy(sma1307->set.header, data,
               sma1307->set.header_size * sizeof(int));

Also since we're immediately copying over the memory in ->set.header,
there is no need to zero it in the allocator.  Use devm_kmalloc_array()
to allocate the memory instead.

Fixes: 576c57e6b4c1 ("ASoC: sma1307: Add driver for Iron Device SMA1307")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aLGjvjpueVstekXP@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/sma1307.c b/sound/soc/codecs/sma1307.c
index 6a601e7134ea2d484cf5a2b42979704af4147a16..b683e676640d899a01aedff3afee66703ab04286 100644 (file)
--- a/sound/soc/codecs/sma1307.c
+++ b/sound/soc/codecs/sma1307.c
@@ -1737,9 +1737,10 @@ static void sma1307_setting_loaded(struct sma1307_priv *sma1307, const char *fil
        sma1307->set.checksum = data[sma1307->set.header_size - 2];
        sma1307->set.num_mode = data[sma1307->set.header_size - 1];
        num_mode = sma1307->set.num_mode;
-       sma1307->set.header = devm_kzalloc(sma1307->dev,
-                                          sma1307->set.header_size,
-                                          GFP_KERNEL);
+       sma1307->set.header = devm_kmalloc_array(sma1307->dev,
+                                                sma1307->set.header_size,
+                                                sizeof(int),
+                                                GFP_KERNEL);
        if (!sma1307->set.header) {
                sma1307->set.status = false;
                return;