]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
rds: Fix endianness annotation for RDS_MPATH_HASH
authorUjwal Kundur <ujwal.kundur@gmail.com>
Wed, 20 Aug 2025 17:55:49 +0000 (23:25 +0530)
committerJakub Kicinski <kuba@kernel.org>
Fri, 22 Aug 2025 23:44:39 +0000 (16:44 -0700)
jhash_1word accepts host endian inputs while rs_bound_port is a be16
value (sockaddr_in6.sin6_port). Use ntohs() for consistency.

Flagged by Sparse.

Signed-off-by: Ujwal Kundur <ujwal.kundur@gmail.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
Link: https://patch.msgid.link/20250820175550.498-4-ujwal.kundur@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/rds/rds.h

index dc360252c51573a1281b14bdba5e530b3bae0b26..5b1c072e2e7ff491684426091d00d11a398e6720 100644 (file)
@@ -93,7 +93,7 @@ enum {
 
 /* Max number of multipaths per RDS connection. Must be a power of 2 */
 #define        RDS_MPATH_WORKERS       8
-#define        RDS_MPATH_HASH(rs, n) (jhash_1word((rs)->rs_bound_port, \
+#define        RDS_MPATH_HASH(rs, n) (jhash_1word(ntohs((rs)->rs_bound_port), \
                               (rs)->rs_hash_initval) & ((n) - 1))
 
 #define IS_CANONICAL(laddr, faddr) (htonl(laddr) < htonl(faddr))