]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
mptcp: sysctl: avail sched: remove write access
authorMatthieu Baerts (NGI0) <matttbe@kernel.org>
Wed, 8 Jan 2025 15:34:29 +0000 (16:34 +0100)
committerJakub Kicinski <kuba@kernel.org>
Thu, 9 Jan 2025 16:53:34 +0000 (08:53 -0800)
'net.mptcp.available_schedulers' sysctl knob is there to list available
schedulers, not to modify this list.

There are then no reasons to give write access to it.

Nothing would have been written anyway, but no errors would have been
returned, which is unexpected.

Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers")
Cc: stable@vger.kernel.org
Reviewed-by: Mat Martineau <martineau@kernel.org>
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20250108-net-sysctl-current-nsproxy-v1-1-5df34b2083e8@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/ctrl.c

index 38d8121331d4a981d4a60ebd8f6cd9482fc2b50c..d9b57fab2a13e64b6c8585e821ed5212f59f8651 100644 (file)
@@ -228,7 +228,7 @@ static struct ctl_table mptcp_sysctl_table[] = {
        {
                .procname = "available_schedulers",
                .maxlen = MPTCP_SCHED_BUF_MAX,
-               .mode = 0644,
+               .mode = 0444,
                .proc_handler = proc_available_schedulers,
        },
        {