]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Unfortunately, xmlNodeGetContent can't be avoided
authorDaniel Lenski <dlenski@gmail.com>
Tue, 9 Jan 2018 08:01:15 +0000 (00:01 -0800)
committerDavid Woodhouse <dwmw2@infradead.org>
Tue, 27 Feb 2018 15:28:32 +0000 (16:28 +0100)
I tested it, and see here: https://stackoverflow.com/a/10441292/20789

Signed-off-by: Daniel Lenski <dlenski@gmail.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
auth-globalprotect.c

index 1e7c854913a1c6ec9cb1559bd9657945d6f1c97c..0c151fec9d2efb03b00a0795a0440cf98cdb8d39 100644 (file)
@@ -127,7 +127,6 @@ static int parse_login_xml(struct openconnect_info *vpninfo, xmlNode *xml_node)
                if (xml_node && !xmlnode_is_named(xml_node, "argument"))
                        goto err_out;
                else if (xml_node) {
-                       /* XX: Could we just use xml_node->content here? */
                        value = (char *)xmlNodeGetContent(xml_node);
                        if (value && (!value[0] || !strcmp(value, "(null)") || !strcmp(value, "-1"))) {
                                free(value);