]> www.infradead.org Git - users/hch/misc.git/commitdiff
media: i2c: ov5640: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:19 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:24 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/ov5640.c

index 0dae0438aa80859aea7f2a3f0be5315ae1bc611a..08ca366a22d7d086633ba97c788deea7357c53d4 100644 (file)
@@ -3898,11 +3898,10 @@ static int ov5640_probe(struct i2c_client *client)
                                               ov5640_dvp_default_fmt;
 
        /* get system clock (xclk) */
-       sensor->xclk = devm_clk_get(dev, "xclk");
-       if (IS_ERR(sensor->xclk)) {
-               dev_err(dev, "failed to get xclk\n");
-               return PTR_ERR(sensor->xclk);
-       }
+       sensor->xclk = devm_v4l2_sensor_clk_get(dev, "xclk");
+       if (IS_ERR(sensor->xclk))
+               return dev_err_probe(dev, PTR_ERR(sensor->xclk),
+                                    "failed to get xclk\n");
 
        sensor->xclk_freq = clk_get_rate(sensor->xclk);
        if (sensor->xclk_freq < OV5640_XCLK_MIN ||