irqchip/mbigen: Simplify code logic with for_each_child_of_node_scoped()

for_each_child_of_node_scoped() handles the device_node automaticlly, so
switching over to it removes the device node cleanups and allows to return
directly from the loop.

Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20240808031552.3156-1-zhangzekun11@huawei.com

diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
index 093fd42893a7aa7a06d353eebf7121f9e1382f36..12919836dadba4706eac4edb21ea284a9c2b2ca9 100644 (file)
--- a/drivers/irqchip/irq-mbigen.c
+++ b/drivers/irqchip/irq-mbigen.c
@@ -222,37 +222,27 @@ static int mbigen_of_create_domain(struct platform_device *pdev,
                                   struct mbigen_device *mgn_chip)
 {
        struct platform_device *child;
-       struct device_node *np;
        u32 num_pins;
-       int ret = 0;
 
-       for_each_child_of_node(pdev->dev.of_node, np) {
+       for_each_child_of_node_scoped(pdev->dev.of_node, np) {
                if (!of_property_read_bool(np, "interrupt-controller"))
                        continue;
 
                child = of_platform_device_create(np, NULL, NULL);
-               if (!child) {
-                       ret = -ENOMEM;
-                       break;
-               }
+               if (!child)
+                       return -ENOMEM;
 
                if (of_property_read_u32(child->dev.of_node, "num-pins",
                                         &num_pins) < 0) {
                        dev_err(&pdev->dev, "No num-pins property\n");
-                       ret = -EINVAL;
-                       break;
+                       return -EINVAL;
                }
 
-               if (!mbigen_create_device_domain(&child->dev, num_pins, mgn_chip)) {
-                       ret = -ENOMEM;
-                       break;
-               }
+               if (!mbigen_create_device_domain(&child->dev, num_pins, mgn_chip))
+                       return -ENOMEM;
        }
 
-       if (ret)
-               of_node_put(np);
-
-       return ret;
+       return 0;
 }
 
 #ifdef CONFIG_ACPI