]> www.infradead.org Git - users/hch/misc.git/commitdiff
f2fs: add error checking in do_write_page()
authormason.zhang <masonzhang.linuxer@gmail.com>
Thu, 31 Jul 2025 15:19:17 +0000 (23:19 +0800)
committerJaegeuk Kim <jaegeuk@kernel.org>
Mon, 11 Aug 2025 17:03:27 +0000 (17:03 +0000)
Otherwise, the filesystem may unaware of potential file corruption.

Signed-off-by: mason.zhang <masonzhang.linuxer@gmail.com>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/segment.c

index cc82d42ef14c58668586a4adb8c52faddf0cccb2..04b0a3c1804d4e43293fea24db90d7208e4be67e 100644 (file)
@@ -3936,12 +3936,18 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio)
        int seg_type = log_type_to_seg_type(type);
        bool keep_order = (f2fs_lfs_mode(fio->sbi) &&
                                seg_type == CURSEG_COLD_DATA);
+       int err;
 
        if (keep_order)
                f2fs_down_read(&fio->sbi->io_order_lock);
 
-       if (f2fs_allocate_data_block(fio->sbi, folio, fio->old_blkaddr,
-                       &fio->new_blkaddr, sum, type, fio)) {
+       err = f2fs_allocate_data_block(fio->sbi, folio, fio->old_blkaddr,
+                       &fio->new_blkaddr, sum, type, fio);
+       if (unlikely(err)) {
+               f2fs_err_ratelimited(fio->sbi,
+                       "%s Failed to allocate data block, ino:%u, index:%lu, type:%d, old_blkaddr:0x%x, new_blkaddr:0x%x, err:%d",
+                       __func__, fio->ino, folio->index, type,
+                       fio->old_blkaddr, fio->new_blkaddr, err);
                if (fscrypt_inode_uses_fs_layer_crypto(folio->mapping->host))
                        fscrypt_finalize_bounce_page(&fio->encrypted_page);
                folio_end_writeback(folio);