]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: zl38060: Setup parent device and get rid of unnecessary of_node assignment
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 2 Dec 2021 20:48:38 +0000 (22:48 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 6 Dec 2021 13:49:27 +0000 (13:49 +0000)
Some of the drivers do not set parent device. This may lead to obstacles
during debugging or understanding the device relations from the Linux
point of view. Assign parent device for GPIO chips created by these
drivers.

While at it, let GPIO library to assign of_node from the parent device.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20211202204838.75287-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/zl38060.c

index d20ec15710106499e7ed288a92df4f92ffbd1fa0..6cae0fb08093b01d110c65a227c2087d7e85edc7 100644 (file)
@@ -589,9 +589,7 @@ static int zl38_spi_probe(struct spi_device *spi)
                                       sizeof(template_chip), GFP_KERNEL);
        if (!priv->gpio_chip)
                return -ENOMEM;
-#ifdef CONFIG_OF_GPIO
-       priv->gpio_chip->of_node = dev->of_node;
-#endif
+       priv->gpio_chip->parent = dev;
        err = devm_gpiochip_add_data(dev, priv->gpio_chip, priv->regmap);
        if (err)
                return err;