]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: codecs: lpass-wsa-macro: Fix using NULL pointer in probe() dev_err
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 28 Jun 2024 09:58:31 +0000 (11:58 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 1 Jul 2024 19:07:29 +0000 (20:07 +0100)
The 'wsa->dev' is assigned closer to the end of the probe() function, so
the dev_err() must not use it - it is still NULL at this point.  Instead
there is already a local 'dev' variable.

Fixes: 727de4fbc546 ("ASoC: codecs: lpass-wsa-macro: Correct support for newer v2.5 version")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patch.msgid.link/20240628095831.207942-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lpass-wsa-macro.c

index 8351f0974e6a6448dc27064ddb656102356372ff..b4e7139bac619a3a1f92b90545bf3dde65086e2d 100644 (file)
@@ -2800,7 +2800,7 @@ static int wsa_macro_probe(struct platform_device *pdev)
                break;
 
        default:
-               dev_err(wsa->dev, "Unsupported Codec version (%d)\n", wsa->codec_version);
+               dev_err(dev, "Unsupported Codec version (%d)\n", wsa->codec_version);
                return -EINVAL;
        }