]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
pwm: lp3943: Use of_property_count_u32_elems() to get property length
authorRob Herring (Arm) <robh@kernel.org>
Wed, 31 Jul 2024 20:14:03 +0000 (14:14 -0600)
committerUwe Kleine-König <ukleinek@kernel.org>
Thu, 5 Sep 2024 09:14:14 +0000 (11:14 +0200)
Replace of_get_property() with the type specific
of_property_count_u32_elems() to get the property length.

This is part of a larger effort to remove callers of of_get_property()
and similar functions. of_get_property() leaks the DT property data
pointer which is a problem for dynamically allocated nodes which may
be freed.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20240731201407.1838385-8-robh@kernel.org
Signed-off-by: Uwe Kleine-König <ukleinek@kernel.org>
drivers/pwm/pwm-lp3943.c

index 61189cea10467089801349c001d0286efca621dc..f0e94c9e5956f0a695032967de8edab9a02c9083 100644 (file)
@@ -218,7 +218,7 @@ static int lp3943_pwm_parse_dt(struct device *dev,
        struct lp3943_platform_data *pdata;
        struct lp3943_pwm_map *pwm_map;
        enum lp3943_pwm_output *output;
-       int i, err, proplen, count = 0;
+       int i, err, count = 0;
        u32 num_outputs;
 
        if (!node)
@@ -234,11 +234,8 @@ static int lp3943_pwm_parse_dt(struct device *dev,
         */
 
        for (i = 0; i < LP3943_NUM_PWMS; i++) {
-               if (!of_get_property(node, name[i], &proplen))
-                       continue;
-
-               num_outputs = proplen / sizeof(u32);
-               if (num_outputs == 0)
+               num_outputs = of_property_count_u32_elems(node, name[i]);
+               if (num_outputs <= 0)
                        continue;
 
                output = devm_kcalloc(dev, num_outputs, sizeof(*output),