]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/xe: Fix a NULL vs IS_ERR() in xe_vm_add_compute_exec_queue()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 7 Aug 2025 15:53:41 +0000 (18:53 +0300)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 15 Sep 2025 12:33:19 +0000 (08:33 -0400)
The xe_preempt_fence_create() function returns error pointers.  It
never returns NULL.  Update the error checking to match.

Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Link: https://lore.kernel.org/r/aJTMBdX97cof_009@stanley.mountain
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/xe/xe_vm.c

index 7b04b392b7296b570d4bec5d954c990845f73360..0cacab20ff8523a5f49f8d9b5d2d42bd2254a295 100644 (file)
@@ -224,8 +224,8 @@ int xe_vm_add_compute_exec_queue(struct xe_vm *vm, struct xe_exec_queue *q)
 
        pfence = xe_preempt_fence_create(q, q->lr.context,
                                         ++q->lr.seqno);
-       if (!pfence) {
-               err = -ENOMEM;
+       if (IS_ERR(pfence)) {
+               err = PTR_ERR(pfence);
                goto out_fini;
        }