]> www.infradead.org Git - users/hch/configfs.git/commitdiff
net: hns3: fix incorrect capability bit display for copper port
authorJian Shen <shenjian15@huawei.com>
Fri, 10 Nov 2023 09:37:09 +0000 (17:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 13 Nov 2023 09:06:58 +0000 (09:06 +0000)
Currently, the FEC capability bit is default set for device version V2.
It's incorrect for the copper port. Eventhough it doesn't make the nic
work abnormal, but the capability information display in debugfs may
confuse user. So clear it when driver get the port type inforamtion.

Fixes: 433ccce83504 ("net: hns3: use FEC capability queried from firmware")
Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index e22279e5d43f35dffedb54d0d4df6fd17664e907..c393b4ee4a320c40eee231ba01b443b1c5e67c65 100644 (file)
@@ -11663,6 +11663,7 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)
                goto err_msi_irq_uninit;
 
        if (hdev->hw.mac.media_type == HNAE3_MEDIA_TYPE_COPPER) {
+               clear_bit(HNAE3_DEV_SUPPORT_FEC_B, ae_dev->caps);
                if (hnae3_dev_phy_imp_supported(hdev))
                        ret = hclge_update_tp_port_info(hdev);
                else