Staging: gdm72xx: Remove unnecessary cast on void pointer

void pointers do not need to be cast to other pointer types.

The semantic patch used to find this:

@r@
expression x;
void* e;
type T;
identifier f;
@@

(
  *((T *)e)
|
  ((T *)x)[...]
|
  ((T *)x)->f
|
- (T *)
  e
)

Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/gdm72xx/gdm_qos.c b/drivers/staging/gdm72xx/gdm_qos.c
index 72c0f7ef8f2bf2236c852821f8e24f2332fc4476..81feffa5784acf9f79bd3b1f2c10401d082d2d3c 100644 (file)
--- a/drivers/staging/gdm72xx/gdm_qos.c
+++ b/drivers/staging/gdm72xx/gdm_qos.c
@@ -59,7 +59,7 @@ static void *alloc_qos_entry(void)
 
 static void free_qos_entry(void *entry)
 {
-       struct qos_entry_s *qentry = (struct qos_entry_s *)entry;
+       struct qos_entry_s *qentry = entry;
        unsigned long flags;
 
        spin_lock_irqsave(&qos_free_list.lock, flags);

diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
index 69f00cc49bad38e88f5ee9c263bab05963687e6a..d9ddced96e194f4020e443ea4faf6e89e512bb71 100644 (file)
--- a/drivers/staging/gdm72xx/gdm_wimax.c
+++ b/drivers/staging/gdm72xx/gdm_wimax.c
@@ -339,7 +339,7 @@ static void gdm_wimax_ind_if_updown(struct net_device *dev, int if_up)
 static int gdm_wimax_open(struct net_device *dev)
 {
        struct nic *nic = netdev_priv(dev);
-       struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf;
+       struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
 
        netif_start_queue(dev);
 
@@ -351,7 +351,7 @@ static int gdm_wimax_open(struct net_device *dev)
 static int gdm_wimax_close(struct net_device *dev)
 {
        struct nic *nic = netdev_priv(dev);
-       struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf;
+       struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
 
        netif_stop_queue(dev);
 
@@ -378,7 +378,7 @@ static int gdm_wimax_ioctl_get_data(struct data_s *dst, struct data_s *src)
        if (src->size) {
                if (!dst->buf)
                        return -EINVAL;
-               if (copy_to_user((void __user *)dst->buf, src->buf, size))
+               if (copy_to_user(dst->buf, src->buf, size))
                        return -EFAULT;
        }
        return 0;
@@ -401,7 +401,7 @@ static int gdm_wimax_ioctl_set_data(struct data_s *dst, struct data_s *src)
                        return -ENOMEM;
        }
 
-       if (copy_from_user(dst->buf, (void __user *)src->buf, src->size)) {
+       if (copy_from_user(dst->buf, src->buf, src->size)) {
                kdelete(&dst->buf);
                return -EFAULT;
        }
@@ -435,7 +435,7 @@ static void gdm_wimax_ind_fsm_update(struct net_device *dev, struct fsm_s *fsm)
 static void gdm_update_fsm(struct net_device *dev, struct fsm_s *new_fsm)
 {
        struct nic *nic = netdev_priv(dev);
-       struct fsm_s *cur_fsm = (struct fsm_s *)
+       struct fsm_s *cur_fsm =
                                        nic->sdk_data[SIOC_DATA_FSM].buf;
 
        if (!cur_fsm)
@@ -483,7 +483,7 @@ static int gdm_wimax_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
                                 * before gdm_wimax_ioctl_set_data is called.
                                 */
                                gdm_update_fsm(dev,
-                                              (struct fsm_s *)req->data.buf);
+                                              req->data.buf);
                        }
                        ret = gdm_wimax_ioctl_set_data(
                                &nic->sdk_data[req->data_id], &req->data);
@@ -798,7 +798,7 @@ cleanup:
 void unregister_wimax_device(struct phy_dev *phy_dev)
 {
        struct nic *nic = netdev_priv(phy_dev->netdev);
-       struct fsm_s *fsm = (struct fsm_s *)nic->sdk_data[SIOC_DATA_FSM].buf;
+       struct fsm_s *fsm = nic->sdk_data[SIOC_DATA_FSM].buf;
 
        if (fsm)
                fsm->m_status = M_INIT;