clk: si5351: implement remove handler

The driver has no remove function, so it does not cleanup
resources that are not under devm management.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

diff --git a/drivers/clk/clk-si5351.c b/drivers/clk/clk-si5351.c
index 20d90769cceda980a0e198919c226e1d86d80c9e..36a15f161dfd4314bd2eefd4a7c3a12a9e7c7a21 100644 (file)
--- a/drivers/clk/clk-si5351.c
+++ b/drivers/clk/clk-si5351.c
@@ -1619,6 +1619,18 @@ err_clk:
        return ret;
 }
 
+static int si5351_i2c_remove(struct i2c_client *client)
+{
+       struct si5351_driver_data *drvdata = i2c_get_clientdata(client);
+
+       of_clk_del_provider(client->dev.of_node);
+       if (!IS_ERR(drvdata->pxtal))
+               clk_disable_unprepare(drvdata->pxtal);
+       if (!IS_ERR(drvdata->pclkin))
+               clk_disable_unprepare(drvdata->pclkin);
+       return 0;
+}
+
 static const struct i2c_device_id si5351_i2c_ids[] = {
        { "si5351a", SI5351_VARIANT_A },
        { "si5351a-msop", SI5351_VARIANT_A3 },
@@ -1634,6 +1646,7 @@ static struct i2c_driver si5351_driver = {
                .of_match_table = of_match_ptr(si5351_dt_ids),
        },
        .probe = si5351_i2c_probe,
+       .remove = si5351_i2c_remove,
        .id_table = si5351_i2c_ids,
 };
 module_i2c_driver(si5351_driver);