]> www.infradead.org Git - users/hch/misc.git/commitdiff
r8152: add error handling in rtl8152_driver_init
authorYi Cong <yicong@kylinos.cn>
Sat, 11 Oct 2025 08:24:15 +0000 (16:24 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 14 Oct 2025 10:07:21 +0000 (12:07 +0200)
rtl8152_driver_init() is missing the error handling.
When rtl8152_driver registration fails, rtl8152_cfgselector_driver
should be deregistered.

Fixes: ec51fbd1b8a2 ("r8152: add USB device driver for config selection")
Cc: stable@vger.kernel.org
Signed-off-by: Yi Cong <yicong@kylinos.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251011082415.580740-1-yicongsrfy@163.com
[pabeni@redhat.com: clarified the commit message]
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/usb/r8152.c

index 44cba7acfe7d9bfbcc96a1e974762657bd1c3c33..a22d4bb2cf3b58e87b1943bc9aac174a2502355c 100644 (file)
@@ -10122,7 +10122,12 @@ static int __init rtl8152_driver_init(void)
        ret = usb_register_device_driver(&rtl8152_cfgselector_driver, THIS_MODULE);
        if (ret)
                return ret;
-       return usb_register(&rtl8152_driver);
+
+       ret = usb_register(&rtl8152_driver);
+       if (ret)
+               usb_deregister_device_driver(&rtl8152_cfgselector_driver);
+
+       return ret;
 }
 
 static void __exit rtl8152_driver_exit(void)