]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/amd/display: remove output_tf_change flag
authorMelissa Wen <mwen@igalia.com>
Mon, 1 Sep 2025 21:51:05 +0000 (18:51 -0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 23 Sep 2025 14:37:01 +0000 (10:37 -0400)
Remove this flag as the driver stopped managing it individually since
commit a4056c2a6344 ("drm/amd/display: use HW hdr mult for brightness
boost"). After some back and forth it was reintroduced as a condition to
`set_output_transfer_func()` in [1]. Without direct management, this
flag only changes value when all surface update flags are set true on
UPDATE_TYPE_FULL with no output TF status meaning.

Fixes: bb622e0c0044 ("drm/amd/display: program output tf when required") [1]
Signed-off-by: Melissa Wen <mwen@igalia.com>
Reviewed-by: Alex Hung <alex.hung@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dc.h
drivers/gpu/drm/amd/display/dc/hwss/dcn20/dcn20_hwseq.c
drivers/gpu/drm/amd/display/dc/hwss/dcn401/dcn401_hwseq.c

index 79de318c85e55f035724f509757642fc947ea19a..98f0b6b3c2136b9e76146b55116afc2a7a710b05 100644 (file)
@@ -1392,7 +1392,6 @@ union surface_update_flags {
                uint32_t in_transfer_func_change:1;
                uint32_t input_csc_change:1;
                uint32_t coeff_reduction_change:1;
-               uint32_t output_tf_change:1;
                uint32_t pixel_format_change:1;
                uint32_t plane_size_change:1;
                uint32_t gamut_remap_change:1;
index 717d2c4daa88a35832be7fdc12cc12764a9f332d..9477c9f9e1963a737228f9d682dc36b04c558345 100644 (file)
@@ -1982,10 +1982,8 @@ static void dcn20_program_pipe(
         * updating on slave planes
         */
        if (pipe_ctx->update_flags.bits.enable ||
-               pipe_ctx->update_flags.bits.plane_changed ||
-               pipe_ctx->stream->update_flags.bits.out_tf ||
-               (pipe_ctx->plane_state &&
-                       pipe_ctx->plane_state->update_flags.bits.output_tf_change))
+           pipe_ctx->update_flags.bits.plane_changed ||
+           pipe_ctx->stream->update_flags.bits.out_tf)
                hws->funcs.set_output_transfer_func(dc, pipe_ctx, pipe_ctx->stream);
 
        /* If the pipe has been enabled or has a different opp, we
index 625653ce555655d49298177aef0c906cf69be5f8..7c276c3190867f3ed1ab0356a029688dc4a2fd1f 100644 (file)
@@ -2032,10 +2032,8 @@ void dcn401_program_pipe(
         * updating on slave planes
         */
        if (pipe_ctx->update_flags.bits.enable ||
-               pipe_ctx->update_flags.bits.plane_changed ||
-               pipe_ctx->stream->update_flags.bits.out_tf ||
-               (pipe_ctx->plane_state &&
-                       pipe_ctx->plane_state->update_flags.bits.output_tf_change))
+           pipe_ctx->update_flags.bits.plane_changed ||
+           pipe_ctx->stream->update_flags.bits.out_tf)
                hws->funcs.set_output_transfer_func(dc, pipe_ctx, pipe_ctx->stream);
 
        /* If the pipe has been enabled or has a different opp, we