]> www.infradead.org Git - users/hch/configfs.git/commitdiff
usbnet: ipheth: do not stop RX on failing RX callback
authorFoster Snowhill <forst@pen.gy>
Tue, 6 Aug 2024 17:28:08 +0000 (19:28 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Aug 2024 12:54:21 +0000 (13:54 +0100)
RX callbacks can fail for multiple reasons:

* Payload too short
* Payload formatted incorrecly (e.g. bad NCM framing)
* Lack of memory

None of these should cause the driver to seize up.

Make such failures non-critical and continue processing further
incoming URBs.

Signed-off-by: Foster Snowhill <forst@pen.gy>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/ipheth.c

index f04c7bf796654f377f526c9fd0955df8dd67e091..cdc72559790a68c162c3f8a03f0248ed39c002dd 100644 (file)
@@ -308,7 +308,6 @@ static void ipheth_rcvbulk_callback(struct urb *urb)
        if (retval != 0) {
                dev_err(&dev->intf->dev, "%s: callback retval: %d\n",
                        __func__, retval);
-               return;
        }
 
 rx_submit: