]> www.infradead.org Git - users/willy/xarray.git/commitdiff
powerpc: powernv: Constify struct kobj_type
authorHuang Xiaojia <huangxiaojia2@huawei.com>
Mon, 26 Aug 2024 15:09:56 +0000 (23:09 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 5 Sep 2024 12:25:36 +0000 (22:25 +1000)
'struct kobj_type' is not modified. It is only used in kobject_init()
which takes a 'const struct kobj_type *ktype' parameter.

Constifying this structure moves some data to a read-only section,
so increase over all security.

On a x86_64, compiled with ppc64 defconfig:
Before:
======
   text    data     bss     dec     hex filename
   3775     256       8    4039     fc7 arch/powerpc/platforms/powernv/opal-dump.o
   2679     260       8    2947     b83 arch/powerpc/platforms/powernv/opal-elog.o

After:
======
   text    data     bss     dec     hex filename
   3823     208       8    4039     fc7 arch/powerpc/platforms/powernv/opal-dump.o
   2727     212       8    2947     b83 arch/powerpc/platforms/powernv/opal-elog.o

Signed-off-by: Huang Xiaojia <huangxiaojia2@huawei.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20240826150957.3500237-2-huangxiaojia2@huawei.com
arch/powerpc/platforms/powernv/opal-dump.c
arch/powerpc/platforms/powernv/opal-elog.c

index 16c5860f13720ca1fad45c6216b6be41e5d7dc77..608e4b68c5ea9d1610e2270b1ba08ed12b69860e 100644 (file)
@@ -210,7 +210,7 @@ static struct attribute *dump_default_attrs[] = {
 };
 ATTRIBUTE_GROUPS(dump_default);
 
-static struct kobj_type dump_ktype = {
+static const struct kobj_type dump_ktype = {
        .sysfs_ops = &dump_sysfs_ops,
        .release = &dump_release,
        .default_groups = dump_default_groups,
index 554fdd7f88b8a1d43e76031465f4229a10dbfb28..5db1e733143bfa8c7cb4bda1ab604e825b3f176f 100644 (file)
@@ -146,7 +146,7 @@ static struct attribute *elog_default_attrs[] = {
 };
 ATTRIBUTE_GROUPS(elog_default);
 
-static struct kobj_type elog_ktype = {
+static const struct kobj_type elog_ktype = {
        .sysfs_ops = &elog_sysfs_ops,
        .release = &elog_release,
        .default_groups = elog_default_groups,