]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
fbdev: uvesafb: Convert sprintf/snprintf to sysfs_emit
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 14 Mar 2024 09:58:13 +0000 (17:58 +0800)
committerHelge Deller <deller@gmx.de>
Fri, 15 Mar 2024 08:25:07 +0000 (09:25 +0100)
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Helge Deller <deller@gmx.de>
CC: linux-fbdev@vger.kernel.org
CC: dri-devel@lists.freedesktop.org
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Helge Deller <deller@gmx.de>
drivers/video/fbdev/uvesafb.c

index e1f421e91b4fb0f297e57cbc3f2bf9571d44a867..73f00c079a9499b51a35dc52d7bb52213849c331 100644 (file)
@@ -1546,7 +1546,7 @@ static ssize_t uvesafb_show_vbe_ver(struct device *dev,
        struct fb_info *info = dev_get_drvdata(dev);
        struct uvesafb_par *par = info->par;
 
-       return snprintf(buf, PAGE_SIZE, "%.4x\n", par->vbe_ib.vbe_version);
+       return sysfs_emit(buf, "%.4x\n", par->vbe_ib.vbe_version);
 }
 
 static DEVICE_ATTR(vbe_version, S_IRUGO, uvesafb_show_vbe_ver, NULL);