]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
ACPI: APEI: EINJ: fix potential NULL dereference in __einj_error_inject()
authorCharles Han <hanchunchao@inspur.com>
Fri, 15 Aug 2025 02:42:06 +0000 (10:42 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 18 Aug 2025 16:10:15 +0000 (18:10 +0200)
The __einj_error_inject() function allocates memory via kmalloc()
without checking for allocation failure, which could lead to a
NULL pointer dereference.

Return -ENOMEM in case allocation fails.

Fixes: b47610296d17 ("ACPI: APEI: EINJ: Enable EINJv2 error injections")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
Reviewed-by: Hanjun Guo <guohanjun@huawei.com>
Link: https://patch.msgid.link/20250815024207.3038-1-hanchunchao@inspur.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/acpi/apei/einj-core.c

index 99f1b841fba9d9e7617f4070678c444ee43a672a..b489ae684a1b014bf39f0f227ea20d275584fc6f 100644 (file)
@@ -540,6 +540,9 @@ static int __einj_error_inject(u32 type, u32 flags, u64 param1, u64 param2,
                struct set_error_type_with_address *v5param;
 
                v5param = kmalloc(v5param_size, GFP_KERNEL);
+               if (!v5param)
+                       return -ENOMEM;
+
                memcpy_fromio(v5param, einj_param, v5param_size);
                v5param->type = type;
                if (type & ACPI5_VENDOR_BIT) {