]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: ethtool: store netdev in a temp variable in ethnl_default_set_doit()
authorJakub Kicinski <kuba@kernel.org>
Sun, 19 Jan 2025 02:05:12 +0000 (18:05 -0800)
committerJakub Kicinski <kuba@kernel.org>
Mon, 20 Jan 2025 19:44:57 +0000 (11:44 -0800)
For ease of review of the next patch store the dev pointer
on the stack, instead of referring to req_info.dev every time.

No functional changes.

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250119020518.1962249-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ethtool/netlink.c

index 849c98e637c6500271d0acac8c3f04c86a066238..c17d8513d4c1f08961634878afaf5480fa2a65ad 100644 (file)
@@ -667,6 +667,7 @@ static int ethnl_default_set_doit(struct sk_buff *skb, struct genl_info *info)
        const struct ethnl_request_ops *ops;
        struct ethnl_req_info req_info = {};
        const u8 cmd = info->genlhdr->cmd;
+       struct net_device *dev;
        int ret;
 
        ops = ethnl_default_requests[cmd];
@@ -688,19 +689,21 @@ static int ethnl_default_set_doit(struct sk_buff *skb, struct genl_info *info)
                        goto out_dev;
        }
 
+       dev = req_info.dev;
+
        rtnl_lock();
-       ret = ethnl_ops_begin(req_info.dev);
+       ret = ethnl_ops_begin(dev);
        if (ret < 0)
                goto out_rtnl;
 
        ret = ops->set(&req_info, info);
        if (ret <= 0)
                goto out_ops;
-       ethtool_notify(req_info.dev, ops->set_ntf_cmd, NULL);
+       ethtool_notify(dev, ops->set_ntf_cmd, NULL);
 
        ret = 0;
 out_ops:
-       ethnl_ops_complete(req_info.dev);
+       ethnl_ops_complete(dev);
 out_rtnl:
        rtnl_unlock();
 out_dev: