]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net: usb: lan78xx: Use action-specific label in lan78xx_mac_reset
authorOleksij Rempel <o.rempel@pengutronix.de>
Mon, 16 Dec 2024 12:09:38 +0000 (13:09 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Dec 2024 03:51:54 +0000 (19:51 -0800)
Rename the generic `done` label to the action-specific `exit_unlock`
label in `lan78xx_mac_reset`. This improves clarity by indicating the
specific cleanup action (mutex unlock) and aligns with best practices
for error handling and cleanup labels.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Link: https://patch.msgid.link/20241216120941.1690908-4-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/usb/lan78xx.c

index 4674051f5c9ccb78b334b70244520dc8df4bf30f..30301af29ab2b1bd9d374f80b2b8ed7b735d3186 100644 (file)
@@ -1604,16 +1604,16 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev)
         */
        ret = lan78xx_mdiobus_wait_not_busy(dev);
        if (ret < 0)
-               goto done;
+               goto exit_unlock;
 
        ret = lan78xx_read_reg(dev, MAC_CR, &val);
        if (ret < 0)
-               goto done;
+               goto exit_unlock;
 
        val |= MAC_CR_RST_;
        ret = lan78xx_write_reg(dev, MAC_CR, val);
        if (ret < 0)
-               goto done;
+               goto exit_unlock;
 
        /* Wait for the reset to complete before allowing any further
         * MAC register accesses otherwise the MAC may lock up.
@@ -1621,16 +1621,16 @@ static int lan78xx_mac_reset(struct lan78xx_net *dev)
        do {
                ret = lan78xx_read_reg(dev, MAC_CR, &val);
                if (ret < 0)
-                       goto done;
+                       goto exit_unlock;
 
                if (!(val & MAC_CR_RST_)) {
                        ret = 0;
-                       goto done;
+                       goto exit_unlock;
                }
        } while (!time_after(jiffies, start_time + HZ));
 
        ret = -ETIMEDOUT;
-done:
+exit_unlock:
        mutex_unlock(&dev->phy_mutex);
 
        return ret;