]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
phy: freescale: fsl-samsung-hdmi: Fix 64-by-32 division cocci warnings
authorAdam Ford <aford173@gmail.com>
Sun, 15 Dec 2024 22:05:55 +0000 (16:05 -0600)
committerVinod Koul <vkoul@kernel.org>
Tue, 24 Dec 2024 15:07:56 +0000 (20:37 +0530)
The Kernel test robot returns the following warning:
 do_div() does a 64-by-32 division, please consider using div64_ul instead.

To prevent the 64-by-32 divsion, consolidate both the multiplication
and the do_div into one line which explicitly uses u64 sizes.

Fixes: 1951dbb41d1d ("phy: freescale: fsl-samsung-hdmi: Support dynamic integer")
Signed-off-by: Adam Ford <aford173@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202412091243.fSObwwPi-lkp@intel.com/
Link: https://lore.kernel.org/r/20241215220555.99113-1-aford173@gmail.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/freescale/phy-fsl-samsung-hdmi.c

index 2c8038864357b14b5f6fbd55312e006fb7cb855f..d3ccf547ba1c2192d6b55685ca316911ba1e3d55 100644 (file)
@@ -424,8 +424,7 @@ static unsigned long fsl_samsung_hdmi_phy_find_pms(unsigned long fout, u8 *p, u1
                         * Fvco = (M * f_ref) / P,
                         * where f_ref is 24MHz.
                         */
-                       tmp = (u64)_m * 24 * MHZ;
-                       do_div(tmp, _p);
+                       tmp = div64_ul((u64)_m * 24 * MHZ, _p);
                        if (tmp < 750 * MHZ ||
                            tmp > 3000 * MHZ)
                                continue;