]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
rds: fix warning in rds_send_drop_to()
authorAjaykumar Hotchandani <ajaykumar.hotchandani@oracle.com>
Thu, 17 Nov 2016 14:16:13 +0000 (06:16 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Tue, 13 Dec 2016 03:33:36 +0000 (19:33 -0800)
This fixes following warning:
warning: 'conn' may be used uninitialized in this function

Orabug: 25116517

Signed-off-by: Ajaykumar Hotchandani <ajaykumar.hotchandani@oracle.com>
net/rds/send.c

index a15759099650194f425f74b238560a505656b4c9..36897d781fa8af42a16d00e81396212de2684ec8 100644 (file)
@@ -865,7 +865,7 @@ EXPORT_SYMBOL_GPL(rds_send_drop_acked);
 void rds_send_drop_to(struct rds_sock *rs, struct sockaddr_in *dest)
 {
        struct rds_message *rm, *tmp;
-       struct rds_connection *conn;
+       struct rds_connection *conn = NULL;
        unsigned long flags;
        LIST_HEAD(list);
        int conn_dropped = 0;
@@ -935,7 +935,7 @@ void rds_send_drop_to(struct rds_sock *rs, struct sockaddr_in *dest)
                 * For a paticular dest and for a sock, all the rms cancelled
                 * belong to the same connection.
                 */
-               if (!conn_dropped && dest &&
+               if (conn && !conn_dropped && dest &&
                    test_bit(RDS_MSG_MAPPED, &rm->m_flags)) {
                        rds_conn_drop(conn, DR_SOCK_CANCEL);
                        conn_dropped = 1;