]> www.infradead.org Git - linux.git/commitdiff
drm/xe/query: Tidy up error EFAULT returns
authorLucas De Marchi <lucas.demarchi@intel.com>
Fri, 11 Oct 2024 03:56:18 +0000 (20:56 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Sat, 12 Oct 2024 02:06:32 +0000 (19:06 -0700)
Move the error handling together in a single branch since all of them
are doing similar thing and return the same error.

Reviewed-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241011035618.1057602-3-lucas.demarchi@intel.com
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
drivers/gpu/drm/xe/xe_query.c

index 69307ff4146a16543b60fb1d027c05ebef549ae0..5093a243e9fe12ad2fd39e12f71a2ec0a8c81abf 100644 (file)
@@ -163,16 +163,10 @@ query_engine_cycles(struct xe_device *xe,
                resp.width = 36;
 
        /* Only write to the output fields of user query */
-       if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp))
-               return -EFAULT;
-
-       if (put_user(resp.cpu_delta, &query_ptr->cpu_delta))
-               return -EFAULT;
-
-       if (put_user(resp.engine_cycles, &query_ptr->engine_cycles))
-               return -EFAULT;
-
-       if (put_user(resp.width, &query_ptr->width))
+       if (put_user(resp.cpu_timestamp, &query_ptr->cpu_timestamp) ||
+           put_user(resp.cpu_delta, &query_ptr->cpu_delta) ||
+           put_user(resp.engine_cycles, &query_ptr->engine_cycles) ||
+           put_user(resp.width, &query_ptr->width))
                return -EFAULT;
 
        return 0;