hwmon: (adt7475) Remove use of i2c_match_id()

The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This is often used to then retrieve the
matching driver_data. This can be done in one step with the helper
i2c_get_match_data().

This helper has a couple other benefits:
 * It doesn't need the i2c_device_id passed in so we do not need
   to have that forward declared, allowing us to remove those or
   move the i2c_device_id table down to its more natural spot
   with the other module info.
 * It also checks for device match data, which allows for OF and
   ACPI based probing. That means we do not have to manually check
   those first and can remove those checks.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20240403203633.914389-6-afd@ti.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index 4224ffb304832e182bcfa4518b768e322a9a6ff6..5f78e66330187dfb01cd36fe1fa107fd6b434b2f 100644 (file)
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1676,7 +1676,6 @@ static int adt7475_probe(struct i2c_client *client)
        struct device *hwmon_dev;
        int i, ret = 0, revision, group_num = 0;
        u8 config3;
-       const struct i2c_device_id *id = i2c_match_id(adt7475_id, client);
 
        data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
        if (data == NULL)
@@ -1686,10 +1685,7 @@ static int adt7475_probe(struct i2c_client *client)
        data->client = client;
        i2c_set_clientdata(client, data);
 
-       if (client->dev.of_node)
-               chip = (uintptr_t)of_device_get_match_data(&client->dev);
-       else
-               chip = id->driver_data;
+       chip = (uintptr_t)i2c_get_match_data(client);
 
        /* Initialize device-specific values */
        switch (chip) {
@@ -1717,7 +1713,7 @@ static int adt7475_probe(struct i2c_client *client)
        if (!(config3 & CONFIG3_SMBALERT))
                data->has_pwm2 = 1;
        /* Meaning of this bit is inverted for the ADT7473-1 */
-       if (id->driver_data == adt7473 && revision >= 1)
+       if (chip == adt7473 && revision >= 1)
                data->has_pwm2 = !data->has_pwm2;
 
        data->config4 = adt7475_read(REG_CONFIG4);
@@ -1730,12 +1726,12 @@ static int adt7475_probe(struct i2c_client *client)
         * because 2 different pins (TACH4 and +2.5 Vin) can be used for
         * this function
         */
-       if (id->driver_data == adt7490) {
+       if (chip == adt7490) {
                if ((data->config4 & CONFIG4_PINFUNC) == 0x1 &&
                    !(config3 & CONFIG3_THERM))
                        data->has_fan4 = 1;
        }
-       if (id->driver_data == adt7476 || id->driver_data == adt7490) {
+       if (chip == adt7476 || chip == adt7490) {
                if (!(config3 & CONFIG3_THERM) ||
                    (data->config4 & CONFIG4_PINFUNC) == 0x1)
                        data->has_voltage |= (1 << 0);          /* in0 */
@@ -1745,7 +1741,7 @@ static int adt7475_probe(struct i2c_client *client)
         * On the ADT7476, the +12V input pin may instead be used as VID5,
         * and VID pins may alternatively be used as GPIO
         */
-       if (id->driver_data == adt7476) {
+       if (chip == adt7476) {
                u8 vid = adt7475_read(REG_VID);
                if (!(vid & VID_VIDSEL))
                        data->has_voltage |= (1 << 4);          /* in4 */
@@ -1829,7 +1825,7 @@ static int adt7475_probe(struct i2c_client *client)
        }
 
        dev_info(&client->dev, "%s device, revision %d\n",
-                names[id->driver_data], revision);
+                names[chip], revision);
        if ((data->has_voltage & 0x11) || data->has_fan4 || data->has_pwm2)
                dev_info(&client->dev, "Optional features:%s%s%s%s%s\n",
                         (data->has_voltage & (1 << 0)) ? " in0" : "",