drm/hisilicon: Remove drm_dev_put in hibmc

Hibmc use the devm_drm_dev_alloc function in hibmc_pci_probe, if
hibmc_pci_probe returns non-zero, devm_drm_dev_alloc will call
devm_drm_dev_init, which will call devm_drm_dev_init_release to
release drm_dev_put. There is no need for hibmc to call
drm_dev_put separately.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1608638156-7879-1-git-send-email-tiantao6@hisilicon.com

diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index 7159018b7287cfdde699ad4d1aaa531b5ba82733..0d4e9023f54d075f4f326fb6309c839052ea08b2 100644 (file)
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -332,13 +332,13 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
        ret = pcim_enable_device(pdev);
        if (ret) {
                drm_err(dev, "failed to enable pci device: %d\n", ret);
-               goto err_free;
+               goto err_return;
        }
 
        ret = hibmc_load(dev);
        if (ret) {
                drm_err(dev, "failed to load hibmc: %d\n", ret);
-               goto err_free;
+               goto err_return;
        }
 
        ret = drm_dev_register(dev, 0);
@@ -354,9 +354,7 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
 
 err_unload:
        hibmc_unload(dev);
-err_free:
-       drm_dev_put(dev);
-
+err_return:
        return ret;
 }