]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/msm/a6xx: Add a comment to acd_probe()
authorAkhil P Oommen <akhilpo@oss.qualcomm.com>
Tue, 2 Sep 2025 11:50:03 +0000 (17:20 +0530)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Tue, 9 Sep 2025 14:25:44 +0000 (17:25 +0300)
It is not obvious why we can skip error checking of
dev_pm_opp_find_freq_exact() API. Add a comment explaining it.

Signed-off-by: Akhil P Oommen <akhilpo@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/672263/
Link: https://lore.kernel.org/r/20250902-assorted-sept-1-v1-4-f3ec9baed513@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/adreno/a6xx_gmu.c

index a719a8d44c1b8d746347bb4b0ab0b027c7f2b6bb..fc62fef2fed87f065cb8fa4e997abefe4ff11cd5 100644 (file)
@@ -1731,6 +1731,7 @@ static int a6xx_gmu_acd_probe(struct a6xx_gmu *gmu)
                u32 val;
 
                freq = gmu->gpu_freqs[i];
+               /* This is unlikely to fail because we are passing back a known freq */
                opp = dev_pm_opp_find_freq_exact(&gpu->pdev->dev, freq, true);
                np = dev_pm_opp_get_of_node(opp);