]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
wifi: qtnfmac: use always-managed version of pcim_intx()
authorPhilipp Stanner <pstanner@redhat.com>
Mon, 9 Dec 2024 13:06:31 +0000 (14:06 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Sat, 18 Jan 2025 20:38:49 +0000 (14:38 -0600)
pci_intx() is a hybrid function which can sometimes be managed through
devres. To remove this hybrid nature from pci_intx(), it is necessary to
port users to either an always-managed or a never-managed version.

qtnfmac enables its PCI device with pcim_enable_device(). Thus, it needs
the always-managed version.

Replace pci_intx() with pcim_intx().

Link: https://lore.kernel.org/r/20241209130632.132074-11-pstanner@redhat.com
Signed-off-by: Philipp Stanner <pstanner@redhat.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Kalle Valo <kvalo@kernel.org>
drivers/net/wireless/quantenna/qtnfmac/pcie/pcie.c

index f66eb43094d4fc8b5819bc2ef0d1ccc209c7ccae..3adcfac2886f14f591b93834125c8d87749597ed 100644 (file)
@@ -204,7 +204,7 @@ static void qtnf_pcie_init_irq(struct qtnf_pcie_bus_priv *priv, bool use_msi)
 
        if (!priv->msi_enabled) {
                pr_warn("legacy PCIE interrupts enabled\n");
-               pci_intx(pdev, 1);
+               pcim_intx(pdev, 1);
        }
 }