]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/arm/komeda: Move pipeline prints to after the entire pipeline has been enabled
authorFaiz Abbas <faiz.abbas@arm.com>
Mon, 19 Feb 2024 10:09:14 +0000 (15:39 +0530)
committerLiviu Dudau <liviu.dudau@arm.com>
Fri, 10 May 2024 10:26:07 +0000 (11:26 +0100)
The komeda driver prints a pretty verbose log in komeda_pipeline_dump()
detailing the components of each of the two pipelines. This gets printed
multiple times during boot as komeda EPROBE_DEFERs waiting for the
remote bridge drivers to come up. Move this log to after this has
happened indicating that the printed pipeline is actually completely up.

Signed-off-by: Faiz Abbas <faiz.abbas@arm.com>
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240219100915.192475-3-faiz.abbas@arm.com
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
drivers/gpu/drm/arm/display/komeda/komeda_crtc.c
drivers/gpu/drm/arm/display/komeda/komeda_kms.h
drivers/gpu/drm/arm/display/komeda/komeda_pipeline.c

index 1a57f5b0ec0a76f1feabbfbae06db437dba013db..2ad33559a33a2b370af3c670802be029532e531c 100644 (file)
@@ -665,6 +665,8 @@ static int komeda_crtc_add(struct komeda_kms_dev *kms,
 
        drm_crtc_enable_color_mgmt(crtc, 0, true, KOMEDA_COLOR_LUT_SIZE);
 
+       komeda_pipeline_dump(pipe);
+
        return 0;
 }
 
index a4048724564dbcfef1b0ed6ef25791cc84f6f6e8..83e61c4080c2753d2837ecc6d6aa29bee508b6b6 100644 (file)
@@ -191,5 +191,6 @@ void komeda_crtc_flush_and_wait_for_flip_done(struct komeda_crtc *kcrtc,
 struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev);
 void komeda_kms_detach(struct komeda_kms_dev *kms);
 void komeda_kms_shutdown(struct komeda_kms_dev *kms);
+void komeda_pipeline_dump(struct komeda_pipeline *pipe);
 
 #endif /*_KOMEDA_KMS_H_*/
index 00f5864a04959ba296b1bacdd16c65f417740269..81e244f0c0ca49d3f3bc286633de80bb26005e5a 100644 (file)
@@ -10,6 +10,7 @@
 #include <drm/drm_print.h>
 
 #include "komeda_dev.h"
+#include "komeda_kms.h"
 #include "komeda_pipeline.h"
 
 /** komeda_pipeline_add - Add a pipeline to &komeda_dev */
@@ -247,7 +248,7 @@ static void komeda_component_dump(struct komeda_component *c)
                  c->max_active_outputs, c->supported_outputs);
 }
 
-static void komeda_pipeline_dump(struct komeda_pipeline *pipe)
+void komeda_pipeline_dump(struct komeda_pipeline *pipe)
 {
        struct komeda_component *c;
        int id;
@@ -351,7 +352,6 @@ int komeda_assemble_pipelines(struct komeda_dev *mdev)
                pipe = mdev->pipelines[i];
 
                komeda_pipeline_assemble(pipe);
-               komeda_pipeline_dump(pipe);
        }
 
        return 0;