phy: mapphone-mdm6600: Fix runtime disable on probe

Commit d644e0d79829 ("phy: mapphone-mdm6600: Fix PM error handling in
phy_mdm6600_probe") caused a regression where we now unconditionally
disable runtime PM at the end of the probe while it is only needed on
errors.

Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
Cc: Merlijn Wajer <merlijn@wizzup.org>
Cc: Miaoqian Lin <linmq006@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Fixes: d644e0d79829 ("phy: mapphone-mdm6600: Fix PM error handling in phy_mdm6600_probe")
Signed-off-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20230913060433.48373-1-tony@atomide.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

diff --git a/drivers/phy/motorola/phy-mapphone-mdm6600.c b/drivers/phy/motorola/phy-mapphone-mdm6600.c
index 1d567604b650d9449d0b07da821ac6907a15d4ca..0147112f77b17e8344e007e53070ba5ac027f013 100644 (file)
--- a/drivers/phy/motorola/phy-mapphone-mdm6600.c
+++ b/drivers/phy/motorola/phy-mapphone-mdm6600.c
@@ -627,10 +627,12 @@ idle:
        pm_runtime_put_autosuspend(ddata->dev);
 
 cleanup:
-       if (error < 0)
+       if (error < 0) {
                phy_mdm6600_device_power_off(ddata);
-       pm_runtime_disable(ddata->dev);
-       pm_runtime_dont_use_autosuspend(ddata->dev);
+               pm_runtime_disable(ddata->dev);
+               pm_runtime_dont_use_autosuspend(ddata->dev);
+       }
+
        return error;
 }