]> www.infradead.org Git - nvme.git/commitdiff
net: dsa: lantiq_gswip: Use dsa_is_cpu_port() in gswip_port_change_mtu()
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Tue, 11 Jun 2024 13:54:29 +0000 (15:54 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 14 Jun 2024 00:07:11 +0000 (17:07 -0700)
Make the check for the CPU port in gswip_port_change_mtu() consistent
with other areas of the driver by using dsa_is_cpu_port().

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Link: https://lore.kernel.org/r/20240611135434.3180973-8-ms@dev.tdt.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/lantiq_gswip.c

index 8ec329d0c136d007d986d13178e075b8473121bd..58c069f964dddbe88854ad710d1f92c5a85c1eac 100644 (file)
@@ -1464,12 +1464,11 @@ static int gswip_port_max_mtu(struct dsa_switch *ds, int port)
 static int gswip_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
 {
        struct gswip_priv *priv = ds->priv;
-       int cpu_port = priv->hw_info->cpu_port;
 
        /* CPU port always has maximum mtu of user ports, so use it to set
         * switch frame size, including 8 byte special header.
         */
-       if (port == cpu_port) {
+       if (dsa_is_cpu_port(ds, port)) {
                new_mtu += 8;
                gswip_switch_w(priv, VLAN_ETH_HLEN + new_mtu + ETH_FCS_LEN,
                               GSWIP_MAC_FLEN);