]> www.infradead.org Git - users/hch/misc.git/commitdiff
r8169: fix packet truncation after S4 resume on RTL8168H/RTL8111H
authorLinmao Li <lilinmao@kylinos.cn>
Thu, 9 Oct 2025 12:25:49 +0000 (20:25 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 14 Oct 2025 00:33:56 +0000 (17:33 -0700)
After resume from S4 (hibernate), RTL8168H/RTL8111H truncates incoming
packets. Packet captures show messages like "IP truncated-ip - 146 bytes
missing!".

The issue is caused by RxConfig not being properly re-initialized after
resume. Re-initializing the RxConfig register before the chip
re-initialization sequence avoids the truncation and restores correct
packet reception.

This follows the same pattern as commit ef9da46ddef0 ("r8169: fix data
corruption issue on RTL8402").

Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
Signed-off-by: Linmao Li <lilinmao@kylinos.cn>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/20251009122549.3955845-1-lilinmao@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index 8903ae90afcbe1457ecae5bd5de809ade8ff78a0..d18734fe12e42ab6af85a2c735314ec9e7b4e7c1 100644 (file)
@@ -4994,8 +4994,9 @@ static int rtl8169_resume(struct device *device)
        if (!device_may_wakeup(tp_to_dev(tp)))
                clk_prepare_enable(tp->clk);
 
-       /* Reportedly at least Asus X453MA truncates packets otherwise */
-       if (tp->mac_version == RTL_GIGA_MAC_VER_37)
+       /* Some chip versions may truncate packets without this initialization */
+       if (tp->mac_version == RTL_GIGA_MAC_VER_37 ||
+           tp->mac_version == RTL_GIGA_MAC_VER_46)
                rtl_init_rxcfg(tp);
 
        return rtl8169_runtime_resume(device);