]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
remoteproc: qcom_wcnss_iris: Simplify with dev_err_probe()
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 11 Oct 2024 13:09:18 +0000 (15:09 +0200)
committerBjorn Andersson <andersson@kernel.org>
Sat, 16 Nov 2024 03:31:47 +0000 (19:31 -0800)
Use dev_err_probe() to make error and defer code handling simpler.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241011-remote-proc-dev-err-probe-v1-10-5abb4fc61eca@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/remoteproc/qcom_wcnss_iris.c

index dd36fd077911afec942f553a55128258c10ba946..b989718776bdb5843bd48b2d724bf1c483725bf3 100644 (file)
@@ -155,9 +155,8 @@ struct qcom_iris *qcom_iris_probe(struct device *parent, bool *use_48mhz_xo)
 
        iris->xo_clk = devm_clk_get(&iris->dev, "xo");
        if (IS_ERR(iris->xo_clk)) {
-               ret = PTR_ERR(iris->xo_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&iris->dev, "failed to acquire xo clk\n");
+               ret = dev_err_probe(&iris->dev, PTR_ERR(iris->xo_clk),
+                                   "failed to acquire xo clk\n");
                goto err_device_del;
        }