firmware: raspberrypi: Improve timeout warning

Recent work on raspberry-power driver showed that even the
stacktrace on firmware property timeout doesn't provide
enough information. So add the first tag name to the warning
to be in line with a status error.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Link: https://lore.kernel.org/r/20240728114200.75559-2-wahrenst@gmx.net
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>

diff --git a/drivers/firmware/raspberrypi.c b/drivers/firmware/raspberrypi.c
index ac34876a97f8b046bc177437118b9c94db580cc7..18cc34987108537c1d39d81ff8866b52d0bee5b3 100644 (file)
--- a/drivers/firmware/raspberrypi.c
+++ b/drivers/firmware/raspberrypi.c
@@ -62,7 +62,6 @@ rpi_firmware_transaction(struct rpi_firmware *fw, u32 chan, u32 data)
                        ret = 0;
                } else {
                        ret = -ETIMEDOUT;
-                       WARN_ONCE(1, "Firmware transaction timeout");
                }
        } else {
                dev_err(fw->cl.dev, "mbox_send_message returned %d\n", ret);
@@ -125,6 +124,8 @@ int rpi_firmware_property_list(struct rpi_firmware *fw,
                dev_err(fw->cl.dev, "Request 0x%08x returned status 0x%08x\n",
                        buf[2], buf[1]);
                ret = -EINVAL;
+       } else if (ret == -ETIMEDOUT) {
+               WARN_ONCE(1, "Firmware transaction 0x%08x timeout", buf[2]);
        }
 
        dma_free_coherent(fw->chan->mbox->dev, PAGE_ALIGN(size), buf, bus_addr);