]> www.infradead.org Git - users/hch/misc.git/commitdiff
mm/damon/core: fix potential memory leak by cleaning ops_filter in damon_destroy_scheme
authorEnze Li <lienze@kylinos.cn>
Tue, 14 Oct 2025 08:42:25 +0000 (16:42 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 21 Oct 2025 22:46:17 +0000 (15:46 -0700)
Currently, damon_destroy_scheme() only cleans up the filter list but
leaves ops_filter untouched, which could lead to memory leaks when a
scheme is destroyed.

This patch ensures both filter and ops_filter are properly freed in
damon_destroy_scheme(), preventing potential memory leaks.

Link: https://lkml.kernel.org/r/20251014084225.313313-1-lienze@kylinos.cn
Fixes: ab82e57981d0 ("mm/damon/core: introduce damos->ops_filters")
Signed-off-by: Enze Li <lienze@kylinos.cn>
Reviewed-by: SeongJae Park <sj@kernel.org>
Tested-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index 4670d293bbf4e8770ac8fbeab6e970aae6d8dbbd..083d314fc4e6ff474a232df84e08fcb1df64e7e1 100644 (file)
@@ -452,6 +452,9 @@ void damon_destroy_scheme(struct damos *s)
        damos_for_each_filter_safe(f, next, s)
                damos_destroy_filter(f);
 
+       damos_for_each_ops_filter_safe(f, next, s)
+               damos_destroy_filter(f);
+
        kfree(s->migrate_dests.node_id_arr);
        kfree(s->migrate_dests.weight_arr);
        damon_del_scheme(s);