net: hns3: replace an unsuitable variable type in hclge_inform_reset_assert_to_vf()

In hclge_inform_reset_assert_to_vf(), variable reset_type(enum type)
will be copied into msg_data whose size is 2 bytes. Currently, hip08
is a little-endian machine, so the lower two bytes of reset_type will
be copied to msg_data. But when running on a big-endian machine,
msg_data will have a wrong value(the higher two bytes of reset_type).

So this patch modifies the type of reset_type to u16, and adds a
build check in case enum hnae3_reset_type has value larger than
U16_MAX.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.h b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
index ed97bd6c03e63a9416d17d026e6d446b59df4729..6b131ab36c7ef689d9bbbc9acdfdb391ab8cde0a 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hnae3.h
+++ b/drivers/net/ethernet/hisilicon/hns3/hnae3.h
@@ -164,6 +164,7 @@ enum hnae3_reset_type {
        HNAE3_IMP_RESET,
        HNAE3_UNKNOWN_RESET,
        HNAE3_NONE_RESET,
+       HNAE3_MAX_RESET,
 };
 
 enum hnae3_flr_state {

diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
index f905dd3386b3b1f74f303e46d002ce99c6b99be7..a3c0822191a957fffb7d08b62432e3bbdf5e2ba3 100644 (file)
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
@@ -86,10 +86,12 @@ static int hclge_send_mbx_msg(struct hclge_vport *vport, u8 *msg, u16 msg_len,
 int hclge_inform_reset_assert_to_vf(struct hclge_vport *vport)
 {
        struct hclge_dev *hdev = vport->back;
-       enum hnae3_reset_type reset_type;
+       u16 reset_type;
        u8 msg_data[2];
        u8 dest_vfid;
 
+       BUILD_BUG_ON(HNAE3_MAX_RESET > U16_MAX);
+
        dest_vfid = (u8)vport->vport_id;
 
        if (hdev->reset_type == HNAE3_FUNC_RESET)