]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/i915/gvt: do not check len & max_len for lri
authorYan Zhao <yan.y.zhao@intel.com>
Wed, 18 Mar 2020 05:48:26 +0000 (13:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Sep 2020 11:47:53 +0000 (13:47 +0200)
commit dbafc67307ec06036b25b223a251af03fe07969a upstream.

lri ususally of variable len and far exceeding 127 dwords.

Fixes: 00a33be40634 ("drm/i915/gvt: Add valid length check for MI variable commands")
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Acked-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20200304095121.21609-1-yan.y.zhao@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/i915/gvt/cmd_parser.c

index fc29a3705354c87a498b9abe848829f7b3e63871..56cd14cacf5e74a97f9b1365f0a251480c6d01ce 100644 (file)
@@ -963,18 +963,6 @@ static int cmd_handler_lri(struct parser_exec_state *s)
        int i, ret = 0;
        int cmd_len = cmd_length(s);
        struct intel_gvt *gvt = s->vgpu->gvt;
-       u32 valid_len = CMD_LEN(1);
-
-       /*
-        * Official intel docs are somewhat sloppy , check the definition of
-        * MI_LOAD_REGISTER_IMM.
-        */
-       #define MAX_VALID_LEN 127
-       if ((cmd_len < valid_len) || (cmd_len > MAX_VALID_LEN)) {
-               gvt_err("len is not valid:  len=%u  valid_len=%u\n",
-                       cmd_len, valid_len);
-               return -EFAULT;
-       }
 
        for (i = 1; i < cmd_len; i += 2) {
                if (IS_BROADWELL(gvt->dev_priv) && s->ring_id != RCS0) {