]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
media: ccs: Fix cleanup order in ccs_probe()
authorMehdi Djait <mehdi.djait@linux.intel.com>
Wed, 11 Dec 2024 13:30:45 +0000 (14:30 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 19 Dec 2024 11:50:14 +0000 (12:50 +0100)
ccs_limits is allocated in ccs_read_all_limits() after the allocation of
mdata.backing. Ensure that resources are freed in the reverse order of
their allocation by moving out_free_ccs_limits up.

Fixes: a11d3d6891f0 ("media: ccs: Read CCS static data from firmware binaries")
Cc: stable@vger.kernel.org
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ccs/ccs-core.c

index e1ae0f9fad4326d765e92ae6086843cfd2ce81e7..cb21df46bab169006eae64996fdec7e22ecf7f82 100644 (file)
@@ -3566,15 +3566,15 @@ out_disable_runtime_pm:
 out_cleanup:
        ccs_cleanup(sensor);
 
+out_free_ccs_limits:
+       kfree(sensor->ccs_limits);
+
 out_release_mdata:
        kvfree(sensor->mdata.backing);
 
 out_release_sdata:
        kvfree(sensor->sdata.backing);
 
-out_free_ccs_limits:
-       kfree(sensor->ccs_limits);
-
 out_power_off:
        ccs_power_off(&client->dev);
        mutex_destroy(&sensor->mutex);