]> www.infradead.org Git - users/griffoul/linux.git/commitdiff
net: phy: aquantia: remove handling for get_rate_matching(PHY_INTERFACE_MODE_NA)
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 21 Aug 2025 15:20:14 +0000 (18:20 +0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 25 Aug 2025 17:54:15 +0000 (10:54 -0700)
After commit 7642cc28fd37 ("net: phylink: fix PHY validation with rate
adaption"), the API contract changed and PHY drivers are no longer
required to respond to the .get_rate_matching() method for
PHY_INTERFACE_MODE_NA. This was later followed up by documentation
commit 6d4cfcf97986 ("net: phy: Update documentation for
get_rate_matching").

As such, handling PHY_INTERFACE_MODE_NA in the Aquantia PHY driver
implementation of this method is unnecessary and confusing. Remove it.

Cc: Sean Anderson <sean.anderson@seco.com>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250821152022.1065237-8-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/aquantia/aquantia_main.c

index 9d704b7e3dc8c8a643e9d9371b6fc4686eea6fa5..0f20ed6f96d8a95231a379de70cb77cb4bcb2fcc 100644 (file)
@@ -1067,8 +1067,7 @@ static int aqr_gen2_get_rate_matching(struct phy_device *phydev,
                                      phy_interface_t iface)
 {
        if (iface == PHY_INTERFACE_MODE_10GBASER ||
-           iface == PHY_INTERFACE_MODE_2500BASEX ||
-           iface == PHY_INTERFACE_MODE_NA)
+           iface == PHY_INTERFACE_MODE_2500BASEX)
                return RATE_MATCH_PAUSE;
        return RATE_MATCH_NONE;
 }